Open
Conversation
Contributor
Author
|
@Otto-AA Can I remove the space from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running mypy in strict mode, the following exception is raised:
Changes
This PR adds a new e2e test that runs mypy in strict mode to catch this class of error early and prevent future regressions. Additionally, the Docker image has been restructured to separate dependency installation from test files — previously, dependencies were being rebuilt on every single run because test files were updated during each run, invalidating the layer cache; now dependencies are built once and subsequent runs simply execute the tests against the pre-built image.